PyUpgrade: Turn errors into OSError #1434
Conversation
|
@colin99d - Is this all set to review? |
|
@charliermarsh I got this done and we are passing all pyupgrade tests. I intentionally left it a little messy because I figured it would need refactored, and I wanted your input on how. This one was a lot more code because there were a lot more possible situations. Also please show me how to get Located out of the box, so that I only need two implement my trait for two types. I tried using (*item).downcast::<Located>(), but rust was saying that Box<Located> has no method downcast (same with downcast_ref). |
|
Ok thanks, I'll try to review today! |
|
(And will look to answer your questions too.) |
|
Perfect! Also is there a Discord server or something similar for people contributing to chat on? |
|
There's not, but I've considered creating one 🤔 |
Would be nice just so that I can know where you plan on taking this thing and how I can help it get there. You could make it private for now if your worried about spammers and randos. |
|
Switched this to draft until I get done with all our changes. |
|
@charliermarsh I am switching this out of draft now. Unfortunately, trying to consolidate to two implementations caused tests to fail, so I did not do it. Let me know if you want anything else cleaned up or more comments anywhere else. |
|
Going to revisit this tomorrow! |
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.205` -> `^0.0.206` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.206`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.206) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.205...v0.0.206) #### What's Changed - PyUpgrade: Turn errors into OSError by [@​colin99d](https://togithub.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/1434](https://togithub.com/charliermarsh/ruff/pull/1434) - Add dark mode variant for benchmark image by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1519](https://togithub.com/charliermarsh/ruff/pull/1519) - Ignore property assignments in RET504 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1520](https://togithub.com/charliermarsh/ruff/pull/1520) - Avoid some false positives for ends-in-period checks by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1521](https://togithub.com/charliermarsh/ruff/pull/1521) - Pyupgrade: `import mock` to `from unittest import mock` by [@​colin99d](https://togithub.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/1488](https://togithub.com/charliermarsh/ruff/pull/1488) - Fix `Name` node range in `NamedExpr` node by [@​harupy](https://togithub.com/harupy) in [https://github.com/charliermarsh/ruff/pull/1526](https://togithub.com/charliermarsh/ruff/pull/1526) - Simplify unused snapshot check by [@​harupy](https://togithub.com/harupy) in [https://github.com/charliermarsh/ruff/pull/1525](https://togithub.com/charliermarsh/ruff/pull/1525) - Do not Change Quotation Style for `SIM118` Autofix by [@​saadmk11](https://togithub.com/saadmk11) in [https://github.com/charliermarsh/ruff/pull/1529](https://togithub.com/charliermarsh/ruff/pull/1529) - Add `visit_format_spec` to avoid false positives for F541 in f-string format specifier by [@​harupy](https://togithub.com/harupy) in [https://github.com/charliermarsh/ruff/pull/1528](https://togithub.com/charliermarsh/ruff/pull/1528) - Rewrite mock.mock attribute accesses by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1533](https://togithub.com/charliermarsh/ruff/pull/1533) **Full Changelog**: astral-sh/ruff@v0.0.205...v0.0.206 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMiJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@charliermarsh If you’re interested, Zulip will happily sponsor free Zulip Cloud hosting for Ruff (as we do for any open-source project). |
](https://renovatebot.com){kind=link}
A part of #827. The following needs to be happen for this to be moved out of draft status:
raisestatements