[red-knot] Minor fix in intersection type comment #14176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
carljm
approved these changes
Nov 7, 2024
sharkdp
force-pushed
the
david/fix-intersection-type-explanation
branch
from
a80d930 to
ee871d4
Compare
sharkdp
commented
Nov 7, 2024
| // | ||
| // However, we do have to leave out the negative contributions. If we were to | ||
| // add a contribution like ~f(N1), we would potentially infer result types | ||
| // that are too narrow, since ~f(A) can be larger than f(~A). |
There was a problem hiding this comment.
It's better not to talk about the size of ~f(A). We should rather compare f(A & ~B) with f(A) & ~f(B). The former can be larger (bool) than the latter (Literal[True]), as demonstrated in the example below.
There was a problem hiding this comment.
Yes, this is the part I was having the hardest time thinking through clearly
There was a problem hiding this comment.
The fully worked example makes it much clearer
carljm
approved these changes
Nov 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor fix in intersection type comment introduced in #14138