[red-knot] Enhancing Diagnostics for Compare Expression Inference #13819
Conversation
cake-monotone
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
|
| } | ||
|
|
||
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| struct OperatorUnsupportedError<'db> { |
There was a problem hiding this comment.
minor nit: perhaps this should be called BinaryOperatorUnsupportedError, since there are also unsupported unary operations, but this error struct is only suitable for carrying information about a binary operator.
There was a problem hiding this comment.
Sorry, should be CompareOperatorUnsupportedError, since this is actually specific to ast.CmpOp. Or maybe for brevity could just be CompareUnsupportedError.
There was a problem hiding this comment.
Actually, it’s coming from the rule name
( https://github.com/astral-sh/ruff/pull/13819/files#diff-65c2c229c88f4021638c996a7496384000d9e7b53b08426b34e92f120bd30b06R2783)
But you're right, CompareUnsupportedError makes more sense! I think the rule name could be updated as well, but it’s a pretty minor thing.
Summary
infer.rs: Changed the return type fromOptiontoResultto lay the groundwork for providing more detailed diagnostics.This is a small step toward improving diagnostics in the future.
Please refer to #13787
Test Plan
mdtest included!