Rename the ruff_vendored crate to red_knot_vendored - #13586
Conversation
|
dhruvmanila
left a comment
There was a problem hiding this comment.
Looks fine to me. Unrelated to this PR, do we need the vendor directory inside the red_knot_vendored crate or should we move the typeshed at the top-level? The double "vendor" was confusing at first but it's fine regardless.
Yeah, I suppose having the I feel like I still weakly prefer having them in a subdirectory for that reason, but definitely don't have a strong opinion |
I don't think I agree with this. Ruff analyze might need the same vendored files if it wants to detect standard library or third party dependencies. I used this name because ruff will use this crate long term. Although that can be said for an red knot module. TLDR: I don't mind this change. |
Well, I feel like we can consider renaming them again when Ruff and red-knot truly merge, but for now it feels very much like part of the red-knot project to me. And renaming is fairly cheap! |
Summary
Following #13436, @carljm and I are no longer getting automated review requests for typeshed-sync PRs: @dhruvmanila had to manually request my review on #13578. That's because our CODEOWNERs file only has us as "owning" paths that have
red_knotin them:ruff/.github/CODEOWNERS
Lines 19 to 21 in 2a36b47
We could just add another line to CODEOWNERS, like we already have for
ruff_db, but renaming the crate has other advantages too:Test Plan
cargo testruff_vendoredanywhere.