Skip to content

[DOCS] Add CrowdCent's numerblox to Ruff users. - #13569

Merged
charliermarsh merged 6 commits into
astral-sh:mainfrom
CarloLepelaars:patch-1
Oct 28, 2024
Merged

[DOCS] Add CrowdCent's numerblox to Ruff users.#13569
charliermarsh merged 6 commits into
astral-sh:mainfrom
CarloLepelaars:patch-1

Conversation

@CarloLepelaars

@CarloLepelaars CarloLepelaars commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Hi, our open source project NumerBlox migrated to uv and ruff. Would appreciate the project being included in the list of Ruff users.

Summary

Add NumerBlox to Ruff users in README.md.

Add CrowdCent to Ruff users
@CarloLepelaars CarloLepelaars changed the title [DOCS] Add CrowdCent numerblox to Ruff users. [DOCS] Add CrowdCent's numerblox to Ruff users. Sep 30, 2024
Add NumerBlox to valid words
Ignore NumerBlox getting flagged as typo

@MichaReiser MichaReiser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the formatting (the pre-commit test is failing)

@CarloLepelaars

Copy link
Copy Markdown
Contributor Author

Could you take a look at the formatting (the pre-commit test is failing)

Hey @MichaReiser, thank you for the reply! The pre-commit thinks NumerBlox is a typo, but it is not.

I tried:

  1. Adding NumerBlox to _typos.toml
  2. Adding inline comment <!-- typos: ignore --> to the README line.

Though these don't work. Do you have an idea on how to make sure the pre-commit doesn't classify NumerBlox as a typo? This is the only obstacle.

@MichaReiser

Copy link
Copy Markdown
Member

Adding it to `types.toml should do the job

@CarloLepelaars

Copy link
Copy Markdown
Contributor Author

I've added NumerBlox to _typos.toml, but unfortunately the pre-commit still fails. Is there something I'm missing?

@calumy

calumy commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

I've added NumerBlox to _typos.toml, but unfortunately the pre-commit still fails. Is there something I'm missing?

Could you try just Numer rather than NumerBlox as this is the bit that typos appears to be trying to correct.

@CarloLepelaars

Copy link
Copy Markdown
Contributor Author

Could you try just Numer rather than NumerBlox as this is the bit that typos appears to be trying to correct.

Thank you for the suggestion @calumy! All CI is passing now!

@MichaReiser
MichaReiser self-requested a review October 8, 2024 06:31
@charliermarsh
charliermarsh merged commit 1f19aca into astral-sh:main Oct 28, 2024
@charliermarsh

Copy link
Copy Markdown
Member

Thank you for the PR @CarloLepelaars. Just as a heads up, I may remove this in the future as I'd like to redo the list to focus it on "highly notable" projects (either significant open source usage or from well-known enterprises).

@CarloLepelaars

Copy link
Copy Markdown
Contributor Author

That's ok @charliermarsh. Thank you for including us in the list in the meantime!

@CarloLepelaars
CarloLepelaars deleted the patch-1 branch October 28, 2024 15:27
@dhruvmanila dhruvmanila added the documentation Improvements or additions to documentation label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants