Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] better docs for type inference #12356

Merged
merged 2 commits into from
Jul 17, 2024
Merged

[red-knot] better docs for type inference #12356

merged 2 commits into from
Jul 17, 2024

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Jul 17, 2024

Add some docs for how type inference works.

Also a couple minor code changes to rearrange or rename for better clarity.

@carljm carljm mentioned this pull request Jul 17, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added the red-knot Multi-file analysis & type inference label Jul 17, 2024
MichaReiser
MichaReiser approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That's very helpful documentation

crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
Base automatically changed from cjm/tests to main July 17, 2024 06:46
@carljm
Copy link
Contributor Author

carljm commented Jul 17, 2024

Thanks, will look at adding these links tomorrow.

@carljm carljm merged commit 985a999 into main Jul 17, 2024
20 checks passed
@carljm carljm deleted the cjm/infer-docs branch July 17, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carljm @MichaReiser