[flake8-bugbear] Use typing.NamedTuple for data classes that only set attributes in an __init__ method (B903) - #12259
Closed
jkauerl wants to merge 8 commits into
Closed
[flake8-bugbear] Use typing.NamedTuple for data classes that only set attributes in an __init__ method (B903)#12259jkauerl wants to merge 8 commits into
flake8-bugbear] Use typing.NamedTuple for data classes that only set attributes in an __init__ method (B903)#12259jkauerl wants to merge 8 commits into
Conversation
jkauerl
marked this pull request as ready for review
July 16, 2024 09:01
flake8-bugbear] Use typing.NamedTuple for data classes that only set attributes in an __init__ method (B902)flake8-bugbear] Use typing.NamedTuple for data classes that only set attributes in an __init__ method (B903)
Collaborator
|
The earlier PR #9601 ended up implementing this rule, which unfortunately makes this a duplicate. (You couldn't have known, since that PR was originally implementing a closely related Apologies for the outcome and the long delay in resolving this, but thank you for your contribution and interest in Ruff - I hope this doesn't discourage you from contributing in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It semi-implements rule B903 from flake8-bugbear. The implementation is working but I need some clarifications regarding what is considerd a class that only set attributes in an
__init__method. This was implemented because it is rule to be implemented in #3758.Test Plan
I implementeed the same test suite as the one located in flake8-bugbear, as such the should behave the same way.
Test suite:
I want to add more test cases because the current implementation is a generalization.