Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-return] Exempt properties from explicit return rule (RET501) #12243

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jul 8, 2024

First contribution - apologies if something is missing

Fixes #12197

@epenet epenet marked this pull request as draft July 8, 2024 13:30
@epenet epenet marked this pull request as ready for review July 8, 2024 13:58
@charliermarsh charliermarsh self-assigned this Jul 8, 2024
@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Jul 8, 2024
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charliermarsh charliermarsh changed the title [flake8-return] Exempt properties (RET501) [flake8-return] Exempt properties from explicit return rule (RET501) Jul 9, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) July 9, 2024 02:24
Copy link

codspeed-hq bot commented Jul 9, 2024

CodSpeed Performance Report

Merging #12243 will not alter performance

Comparing epenet:20240708-1515 (9e08538) with main (bf3d903)

Summary

✅ 33 untouched benchmarks

@charliermarsh charliermarsh merged commit 2041b0e into astral-sh:main Jul 9, 2024
20 checks passed
@epenet epenet deleted the 20240708-1515 branch July 9, 2024 06:21
@epenet epenet mentioned this pull request Jul 9, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RET501 should exempt properties
2 participants