[flake8-bandit
] fix S113 false positive for httpx without timeout
argument
#12213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
S113 exists because
requests
doesn't have a default timeout, so request without timeout may hang indefinitelyBut httpx has default timeout 5s, so S113 for httpx request without
timeout
argument is a false positive, only valid case would betimeout=None
.https://www.python-httpx.org/advanced/timeouts/
Test Plan
snap updated