Consider --preview
flag for server
subcommand
#12208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the requirement of
--preview
flag to run theruff server
and instead considers it to be an indicator to turn on preview mode for the linter and the formatter.resolves: #12161
Test Plan
Add test cases to assert the
preview
value is updated accordingly.In an editor context, I used the local
ruff
executable in Neovim with the--preview
flag and verified that the preview-only violations are being highlighted.Running with:
The screenshot shows that
E502
is highlighted with the below config inpyproject.toml
: