Remove demisto/content from ecosystem checks - #12129
Merged
Merged
Conversation
charliermarsh
force-pushed
the
charlie/eco
branch
from
July 1, 2024 02:15
b240ed6 to
0053c5a
Compare
Contributor
|
dhruvmanila
approved these changes
Jul 1, 2024
Member
|
Huh, weird that it's not reflecting in the ecosystem comment on this PR. Edit: I'm rerunning the job. |
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
CodSpeed Performance ReportMerging #12129 will improve performances by 7.57%Comparing Summary
Benchmarks breakdown
|
dhruvmanila
added a commit
that referenced
this pull request
Jul 3, 2024
## Summary Follow-up to #12129 to remove the `demisto/content` from ecosystem checks. The previous PR removed it from the deprecated script which I didn't notice until recently. ## Test Plan Ecosystem comment
KotlinIsland
pushed a commit
to KotlinIsland/basedpython
that referenced
this pull request
May 1, 2026
## Summary Follow-up to astral-sh/ruff#12129 to remove the `demisto/content` from ecosystem checks. The previous PR removed it from the deprecated script which I didn't notice until recently. ## Test Plan Ecosystem comment
ntBre
pushed a commit
that referenced
this pull request
Jul 29, 2026
## Summary Reintroducing `demisto/content` back to `ruff-ecosystem`, it's a huge repo with 4.5K py file and 2.5M loc, so may have catch some cases for ecosystem report. It was previously commented out in #12129 due to the use of removed `E999` Issue with the use of removed rules upstream is resolved, though apparently `E999` was dropped from selection a while ago and new issue with the use of removed `UP038` occurred, but it's resolved now too - demisto/content#45227 Syntax error in still present in https://github.com/demisto/content/blob/master/Packs/ThreatQ/Integrations/ThreatQ/ThreatQ.py, so keeping `exclude`. Though apparently it doesn't break `ruff-ecosystem` anymore, but keeping it safe for now. I've submitted a fix upstream demisto/content#45275, so `exclude` can be removed later too. ## Test Plan Tested running `ruff-ecosystem` locally, no issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unfortunately
demisto/contentuses an explicitselectforE999, so it will always fail in preview. And they're on a fairly old version. I'd like to keep checking it, but seems easiest for now to just disable it.In response, I've added a few new repos.