Build CommentRanges outside the parser
#11792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/lazy-comment-ranges
branch
from
7985dff to
c3c5475
Compare
dhruvmanila
commented
Jun 7, 2024
Comment on lines
+513
to
+524
| impl From<&Tokens> for CommentRanges { | ||
| fn from(tokens: &Tokens) -> Self { | ||
| let mut ranges = vec![]; | ||
| for token in tokens { | ||
| if token.kind() == TokenKind::Comment { | ||
| ranges.push(token.range()); | ||
| } | ||
| } | ||
| CommentRanges::new(ranges) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this is a better approach to create CommentRanges instead of CommentRangesBuilder. This is the primary way of building the CommentRanges outside the linter. In the linter, the Indexer creates it because it's already looping over the tokens.
|
MichaReiser
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the parser to remove building the
CommentRangesand instead it'll be built by the linter and the formatter when it's required.For the linter, it'll be built and owned by the
Indexerwhile for the formatter it'll be built from theTokensstruct and passed as an argument.Test Plan
cargo insta test