Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use owned ast and tokens in bench #11598

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented May 29, 2024

Summary

Use owned values for the linter benchmark as preparation for the parser refactor

The perf regressions come from the fact that the tokens and ast are now dropped inside the benchmark. I think this is good, because that is closer to what we see in production.

@MichaReiser MichaReiser added the internal An internal refactor or improvement label May 29, 2024
@MichaReiser MichaReiser force-pushed the use-owned-ast-and-tokens-in-bench branch 2 times, most recently from a3ecb59 to 86a3636 Compare May 29, 2024 11:12
Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #11598 will degrade performances by 15.62%

Comparing use-owned-ast-and-tokens-in-bench (9517a4d) with main (7659114)

Summary

❌ 5 (👁 5) regressions
✅ 25 untouched benchmarks

Benchmarks breakdown

Benchmark main use-owned-ast-and-tokens-in-bench Change
👁 linter/all-rules[large/dataset.py] 16.2 ms 16.9 ms -4.32%
👁 linter/default-rules[large/dataset.py] 3.6 ms 4.3 ms -15.62%
👁 linter/default-rules[numpy/ctypeslib.py] 904.6 µs 1,011.7 µs -10.58%
👁 linter/default-rules[pydantic/types.py] 1.9 ms 2.1 ms -12.29%
👁 linter/default-rules[unicode/pypinyin.py] 350.7 µs 405.2 µs -13.47%

Copy link
Contributor

github-actions bot commented May 29, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser requested a review from dhruvmanila May 29, 2024 11:41
@MichaReiser MichaReiser force-pushed the use-owned-ast-and-tokens-in-bench branch from 86a3636 to 9517a4d Compare May 29, 2024 11:43
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichaReiser MichaReiser merged commit 921bc15 into main May 29, 2024
19 checks passed
@MichaReiser MichaReiser deleted the use-owned-ast-and-tokens-in-bench branch May 29, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants