[refurb] Do not allow any keyword arguments for read-whole-file in rb mode (FURB101) - #10803
Merged
charliermarsh merged 1 commit intoApr 6, 2024
Merged
Conversation
augustelalande
changed the title
refurb] Do not allow any keyword arguments for read-whole-file in rb moderefurb] Do not allow any keyword arguments for read-whole-file in rb mode (FURB101)
charliermarsh
approved these changes
Apr 6, 2024
Contributor
|
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
Apr 12, 2024
…n `rb` mode (`FURB101`) (astral-sh#10803) ## Summary `Path.read_bytes()` does not support any keyword arguments, so `FURB101` should not be triggered if the file is opened in `rb` mode with any keyword arguments. ## Test Plan Move erroneous test to "Non-error" section of fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path.read_bytes()does not support any keyword arguments, soFURB101should not be triggered if the file is opened inrbmode with any keyword arguments.Test Plan
Move erroneous test to "Non-error" section of fixture.