Ignore Q000, Q001 when string is inside forward ref - #10585
Merged
Conversation
AlexWaygood
approved these changes
Mar 25, 2024
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Makes sense as a quick fix 👍
dhruvmanila
force-pushed
the
dhruv/ignore-in-forward-ref
branch
from
March 25, 2024 18:44
dd1923a to
3638dac
Compare
dhruvmanila
enabled auto-merge (squash)
March 25, 2024 18:44
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is not the holistic solution but just to fix that issue.
fixes: #10546
Test Plan
Add a regression test for it and check the snapshots.