Skip to content

Use ruff.toml format in README - #10393

Merged
charliermarsh merged 1 commit into
mainfrom
charlie/c
Mar 13, 2024
Merged

Use ruff.toml format in README#10393
charliermarsh merged 1 commit into
mainfrom
charlie/c

Conversation

@charliermarsh

Copy link
Copy Markdown
Member

Summary

See feedback in #4725 (comment).

In the docs, we use a tabbed interface for express ruff.toml vs. pyproject.toml. Here, it might be clearer to default to ruff.toml, since it's more obviously not pyproject.toml. But either way, this PR attempts to clarify that there's a difference.

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Mar 13, 2024
Comment thread README.md Outdated
The remaining configuration options can be provided through a catch-all `--config` argument:

```shell
ruff check path/to/code/ --config "lint.per-file-ignores = {'some_file.py' = ['F841']}"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love path/to/code/ here it seems like a bad example as a corollary for file discovery options.

I know it's copied from above but maybe a good time to improve

@zanieb zanieb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charliermarsh
charliermarsh enabled auto-merge (squash) March 13, 2024 18:42
@charliermarsh
charliermarsh merged commit e9d3f71 into main Mar 13, 2024
@charliermarsh
charliermarsh deleted the charlie/c branch March 13, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants