Respect external codes in file-level exemptions - #10203
Merged
Merged
Conversation
charliermarsh
added
bug
charliermarsh
force-pushed
the
charlie/ext
branch
from
March 3, 2024 00:06
d6b6488 to
f2e5f7e
Compare
charliermarsh
enabled auto-merge (squash)
March 3, 2024 00:07
CodSpeed Performance ReportMerging #10203 will improve performances by 5.33%Comparing Summary
Benchmarks breakdown
|
charliermarsh
force-pushed
the
charlie/ext
branch
from
March 3, 2024 00:13
f2e5f7e to
1f652b7
Compare
Contributor
|
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this pull request
Mar 10, 2024
We shouldn't warn when an "external" code is used in a file-level exemption. Closes astral-sh#10202.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't warn when an "external" code is used in a file-level exemption.
Closes #10202.