Skip to content

[pydocstyle] Trim whitespace when removing blank lines after section (D413) - #10162

Merged
MichaReiser merged 3 commits into
astral-sh:mainfrom
jusexton:fix-d413-issue
Feb 29, 2024
Merged

[pydocstyle] Trim whitespace when removing blank lines after section (D413)#10162
MichaReiser merged 3 commits into
astral-sh:mainfrom
jusexton:fix-d413-issue

Conversation

@jusexton

@jusexton jusexton commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Summary

Fixes #10050

Test Plan

Added additional scenario to D413.py and updated snapshots.

@jusexton jusexton changed the title Fixed bug applying whitespace when applying fix for D413. Fixed bug creating unecessary whitespace when applying fix for D413. Feb 29, 2024
@github-actions

github-actions Bot commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

@MichaReiser MichaReiser added the fixes Related to suggested fixes for violations label Feb 29, 2024
@MichaReiser MichaReiser changed the title Fixed bug creating unecessary whitespace when applying fix for D413. [pydocstyle] Trim whitespace when removing blank lines after section (D413) Feb 29, 2024
@MichaReiser

Copy link
Copy Markdown
Member

Thank you

@MichaReiser
MichaReiser enabled auto-merge (squash) February 29, 2024 13:23
@MichaReiser
MichaReiser merged commit c73c497 into astral-sh:main Feb 29, 2024
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
…n (`D413`) (astral-sh#10162)

Co-authored-by: Micha Reiser <micha@reiser.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixes Related to suggested fixes for violations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix for D413 introduces whitespace

2 participants