Support for Jupyter Notebooks

[advait404]

Hi, currently the extension does not perform linting for jupyter notebooks. I have tried adding "include = [".py", ".pyi", "**/pyproject.toml", "*.ipynb"]" into the pyproject.toml but it still fails to work.

• running on windows 10
• latest extension version
• VScodium version 1.79.2

setting.json

  "ruff.args": [
    "--config=D:/Portable Apps/VSCodium/data/pyproject.toml",
  ],

pyproject.toml

[tool.ruff]
select = ["ALL"]
ignore = ["ERA001","E501"]
include = ["*.py", "*.pyi", "**/pyproject.toml", "*.ipynb"]

[charliermarsh]

@dhruvmanila - Do you know if Jupyter linting is enable-able in the current version of the extension? (I can also test this tomorrow.)

[charliermarsh]

@advait404 - Do you mind also confirming your Ruff version? Are you using the version that ships with the extension, or do you have Ruff installed in your environment?

[advait404]

I am using the ruff version bundled with the extension. Extension version is 2023.32.0

[dhruvmanila]

No, Jupyter Notebook in VSCode isn't supported yet. I think it'll require some changes in ruff-lsp to support it. I'll look into it - me and @konstin discussed this briefly on Discord.

[markeyser]

Please, fix this issue; we will move to Ruff in my 80-people AI team in the coming weeks. We use VS Code notebooks as much as Python scripts.

[zanieb]

As an update, we're planning to do this — you can see the status of Jupyter notebook support over in astral-sh/ruff#5188

Requires openlawlibrary/pygls#356

[blakeNaccarato]

Your team may already be aware of this, but in addition to completion of openlawlibrary/pygls#356, the VSCode September 2023 release finalizes the notebook Code Action API and includes the Notebook CodeActionKind. This results in notebook.source.-prefixed actions which have the full-notebook scope. This may be relevant to your implementation here, along with whatever changes may be needed in ruff-lsp. See also the related:

• API Finalization -- Support for Notebook CodeActionKind microsoft/vscode#193120

[dhruvmanila]

Interesting, thanks for letting us know! I was not aware of this. I'll give it a detailed look later but I don't think this is useful to us as our extension is based on ruff-lsp which is based on the LSP protocol. And IIUC, this is specific to the VSCode extension.