Repository navigation
Fix invalid escape sequences in the OpenSSL props literals (cpython-windows/build.py) - #1242
Merged
jjhelmus merged 1 commit intoAug 31, 2026
Conversation
OPENSSL_PROPS_REMOVE_RULES and OPENSSL_PROPS_REMOVE_RULES_LEGACY are non-raw bytes literals containing \libcrypto and \libssl, so Python reads \l as an escape sequence and warns on every build. Marking both raw leaves their contents unchanged.
Contributor
|
LGTM, thanks for the fix. |
Contributor
Author
|
Thanks a lot for a quick merge! |
vadikmironov
added a commit
to vadikmironov/omniglot-bazel-starter
that referenced
this pull request
Aug 31, 2026
The raw bytes literals landed in astral-sh/python-build-standalone#1242, so applying the patch on top of current main conflicts and the whole series fails before any build starts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPENSSL_PROPS_REMOVE_RULESandOPENSSL_PROPS_REMOVE_RULES_LEGACYare non-raw bytes literals containing\libcryptoand\libssland Python reads\las an escape sequence.Running any build triggers it:
The build still works alright - an unrecognised escape is left as the literal characters. At this stage it is more of a cleanup as nothing broken. It reduces the number of warnings that would otherwise be picked by build monitor. If invalid escapes are ever promoted to an error as suggested in 3.12 changelog, the build will fail.
The fix is straightforw - mark both literals raw fixes it.