Repository navigation
Cherry-pick an improved DER parser in _ssl.c from 3.12 onto 3.10 and 3.11 - #1147
Merged
Merged
Conversation
Cherry-pick an improved DER parser in 3.12 that is not sensitive to a minor change in error message in the new OpenSSL version.
geofft
added
platform:windows
Contributor
|
Should this patch be applied on Windows, e.g. in |
Collaborator
Author
|
That seems like a really good idea, yes... I'm including the patch twice, once in cpython-unix and once in cpython-windows, to avoid thinking about symlinks or about .., but I can read the patch out of cpython-unix if that seems better. |
jjhelmus
approved these changes
Jun 10, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the inability to load DER correctly with OpenSSL 3.5.7.