Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads up for planned jni-sys updates #65

Closed
rib opened this issue Jul 25, 2023 · 1 comment
Closed

Heads up for planned jni-sys updates #65

rib opened this issue Jul 25, 2023 · 1 comment

Comments

@rib
Copy link

rib commented Jul 25, 2023

Heya, I just wanted to make sure to give a heads up here that I've been chipping away at some maintenance chores for jni-sys and based on issues I've seen while working on the jni crate I was planning a few semver breaking changes.

It'd be good if you can take a look at the 'Release 0.4' milestone here: https://github.com/jni-rs/jni-sys/milestone/1

The two notable changes are:

  1. making jboolean an alias for bool: ref Considering redefining jboolean as either an bool or our own #[repr(u8)] enum jni-rs/jni-sys#19, Add Array wrapper types with lifetimes jni-rs/jni-rs#400 (comment) and Make jboolean an alias for bool instead of u8 jni-rs/jni-sys#23
  2. Turning JNINativeInterface + JNIInvokeInterface_ into unions that namespace function pointers by the JNI version they were added (and remove the misleading Option wrappers), ref: Turn JNINativeInterface + JNIInvokeInterface_ into unions jni-rs/jni-sys#28 and Removes the Options around the function pointers jni-rs/jni-sys#25

The latter change in particular may invole some boilerplate changes here but at least as far as the jni crate goes I'm glad I looked at this this since it has highlighted several places where the jni crate was using > 1.1 functions without checking the version at runtime.

@astonbitecode
Copy link
Owner

Thanks for the heads-up, much appreciated.

This was parked for some time, but I guess the time has come to deal with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants