This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Remove option for context isolation #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the option to set `ContextIsolation` from `WindowOptions.WebPreferences`. The property is now hardcoded to false in astilectron (see asticode/astilectron#45).
|
CI tests fail, but I think the problem lies elsewhere (something about strings containing an extra |
Yeah you're right, just fixed it |
|
Could you update And let me know in a comment when it's done so that I'm notified? |
|
Done. |
|
FYI I've created new tags for the whole ecosystem Cheers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the option to set
ContextIsolationfromWindowOptions.WebPreferences. The property is now hardcoded to false in astilectron (see asticode/astilectron#45).Context isolation appears to be incompatible with astilectron, but it's enabled by default by Electron starting with major version 12.
Issue: #318