This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asticode
suggested changes
Mar 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR sounds good, just a few minor changes though.
Cheers
options.go
Outdated
@@ -9,6 +9,7 @@ type Options struct { | |||
Asset Asset | |||
AstilectronOptions astilectron.Options | |||
Debug bool | |||
HomeResource string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather you name the variable ResourcesPath
run.go
Outdated
@@ -45,12 +45,17 @@ func Run(o Options) (err error) { | |||
a.SetProvisioner(astibundler.NewProvisioner(o.Asset)) | |||
} | |||
|
|||
var homeResource string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, could you name the variable resourcesPath
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Cheers |
asticode
pushed a commit
that referenced
this pull request
Mar 26, 2018
* add HomeDirectory setting * add HomeResources path setting * remove unused package * add custom resources path * modify attrName HomeResources to ResourcesPath * format tab * modify attrName to resourcesPath
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm use the go-astilectron-demo firstly. It use "resources" structure, like the code in main.go.
resources structure:
main.go:
Yet in
go-astilectron-bundler
provide a way that change resources path in bundler.go:It can customly config resources_path in bundler.json to set the resources path, such as:
However in
go-astilectron-bootstrap
is use stable path in homepage and restoreAssets in run.go:I add
HomeResources
attr to help set the customly path setting in bootstrap.I think if you merge this PR, It may have some changes with
go-astilectron-demo