Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument parsing of the command line utility #333

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

frsche
Copy link
Contributor

@frsche frsche commented Jul 9, 2024

The expected arguments in the command line utility do not match the help description. Furthermore, the long "--output" parameter was missing the following filename, and "--align" was later expected to be called "--colalign".

@astanin astanin merged commit 7d8e8b3 into astanin:master Sep 26, 2024
1 check failed
@astanin
Copy link
Owner

astanin commented Sep 26, 2024

It would be nice to improve the CLI. At the moment it remains largely untested and undocumented.

  • test/test_cli.py does not test all command line arguments and their behavior
  • usage info in the README is not up to date (colalign is not mentioned there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants