Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for separating lines #279

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

pjkundert
Copy link
Contributor

@pjkundert pjkundert commented Jul 20, 2023

Resolves #246

@davidlatte
Copy link

It would be great to get this PR merged and released!

@astanin
Copy link
Owner

astanin commented Sep 27, 2024

I tried merging this commit with master (see pr-279 branch), but the tests fail in test_simple_headerless_with_sep_line_with_linebetweenrows_in_tablefmt.

Expected output:

+------+----------+
| spam |  41.9999 |
+------+----------+
+------+----------+
| eggs | 451      |
+------+----------+

actual output:

+------+----------+
| spam |  41.9999 |
+------+----------+
||
+------+----------+
| eggs | 451      |
+------+----------+

Possible interaction with the changes introduced in pull request #331.
Or I might have broken it during the merge.

@astanin astanin added the incomplete This PR requires some further changes or modifications before it can be merged. label Sep 27, 2024
@pjkundert
Copy link
Contributor Author

A check for SEPARATING_LINE got skipped, @astatin; I added it back in. Passes tests now.

@astanin
Copy link
Owner

astanin commented Oct 8, 2024

@pjkundert Thank you. I think this can be merged now.

@astanin astanin merged commit 048a22c into astanin:master Oct 8, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incomplete This PR requires some further changes or modifications before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a SEPARATING_LINE fails, for any format with padding
3 participants