feat: API for Node child_with_descendant #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #[inline] | ||
| pub fn child_with_descendant(&self, descendant: Self) -> Option<Self> { | ||
| self.inner.child_with_descendant(descendant.inner).map(Into::into) |
Member
There was a problem hiding this comment.
question, what's the version of tree-sitter has this method?
Member
Author
There was a problem hiding this comment.
v0.24.0, though before that a similar method called child_containing_descendant existed (deprecated in 0.24, removed in 0.25)
Member
|
I read relevant info here neovim/neovim#28512 and neovim/neovim#30516 amzing perf improvement! |
HerringtonDarkholme
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides access to the
child_with_descendantnode function, allowing for more efficient searches for, e.g., nodes containing certain ancestors