RMA-101184: code changes in halstack lib #159
Conversation
216 build server not supported the NPM and Node and NVM versions. Hence not able to continue our build process...
Update package.json
Update package.json
Feature/rma 98688 Multiline labels
multiline label issue
…halstack-angular into feature/RMA-100989
Feature/rma 100989
feature/RMA-101210: checkin on behalf of vishal
assureclaims
left a comment
assureclaims
left a comment
There was a problem hiding this comment.
still code is missed for supporting reactive form
| /** | ||
| * request object gets the value from APP and pass to halstack library. | ||
| */ | ||
| @Input('requests') requests: IfileuploadRequest = null; |
There was a problem hiding this comment.
IfileuploadRequest check the case - Change it to IFileUploadRequest
| hasErrorSingleFile: boolean = false; | ||
| hasValue: boolean = false; | ||
|
|
||
| global_filehit: number = 0; |
There was a problem hiding this comment.
use camel case for all properties and functions name
global_filehit: number = 0; should be like globalFileHit
global_chunkcount: number = 0;
global_actualchunkcount: number = 0;
filedataupload: filemetadata;
GUID: string;
fileEventType: EventType = EventType.PREUPLOAD;
chunkresult: boolean;
Postresp: any;
| * @param event | ||
| */ | ||
| processFiles(event) { | ||
| // var len = event.length; |
| // }); | ||
| this.uploadChunkDoc(eventFiles); | ||
| } | ||
| uploadChunkDoc(file) { |
There was a problem hiding this comment.
should be private if not calling from html
| @@ -0,0 +1,7 @@ | |||
| import { chunkmetadata } from "./chunkmetadata"; | |||
|
|
|||
| export class filemetadata { | |||
There was a problem hiding this comment.
filemetadata should be pascal case FileMetadata
| @@ -0,0 +1,323 @@ | |||
| import { HttpParams, HttpHeaders } from '@angular/common/http'; | |||
There was a problem hiding this comment.
why copied the configuration model file in side dxc-file-input
| @@ -0,0 +1,16 @@ | |||
| import { IRequest } from './configuration.model'; | |||
There was a problem hiding this comment.
changes the name of file this is not a service file this is models related to file upload component. and move the file in modles folder
| @@ -0,0 +1,103 @@ | |||
| export interface ILookup { | |||
There was a problem hiding this comment.
why copy the lookupmodel in side dxc-file input ?
| @@ -0,0 +1,25 @@ | |||
| export declare class Lookup { | |||
There was a problem hiding this comment.
why copy the lookup.ts in side dxc-file input ?
| //let data = this.getPreview(file); | ||
| this.data[0].eventtype = this.fileEventType; | ||
| this.callbackFile.emit(this.data); | ||
| alert("File Upload completed"); }); |
| import { NgChanges } from "../typings/ng-onchange"; | ||
| import { FileInputProperties, Space, Spacing } from "./dxc-file-input.types"; | ||
| import { FileMetaData } from './model/filemetadata'; | ||
| import { chunkmetadata } from './model/chunkmetadata'; |
| hasErrorSingleFile: boolean = false; | ||
| hasValue: boolean = false; | ||
|
|
||
| globalFileHit: number = 0; |
projects/dxc-ngx-cdk/src/lib/dxc-file-input/dxc-file-input.component.ts
Outdated
Show resolved
Hide resolved
projects/dxc-ngx-cdk/src/lib/dxc-file-input/dxc-file-input.component.ts
Outdated
Show resolved
Hide resolved
projects/dxc-ngx-cdk/src/lib/dxc-file-input/dxc-file-input.component.ts
Outdated
Show resolved
Hide resolved
| throw new Error(`Error! status: ${response.status}`); | ||
| } | ||
| } | ||
| private async uploadcomplete(theFiles: FileMetaData) { |
There was a problem hiding this comment.
uploadcomplete still not camel case
RMA-101184