fix: Deprecate cargo_bin (runtime version) #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18889989393Details
💛 - Coveralls |
smoelius
reviewed
Oct 31, 2025
| /// [`Command`]: std::process::Command | ||
| #[deprecated( | ||
| since = "2.1.0", | ||
| note = "incompatible with a custom cargo build-dir, see instead `cargo::cargo_bin!`" |
Contributor
There was a problem hiding this comment.
I am confused by this deprecation notice. Does "custom cargo build-dir" mean custom target directory, e.g., as one would specify with CARGO_TARGET_DIR?
The incompatibility is not related to changing the build directory within the target directory (e.g., target/debug/build), correct?
If it is neither of these, could you please point me to a reference?
Contributor
Author
There was a problem hiding this comment.
Rust 1.91 split a build-dir out of target-dir with the default falling back to target-dir, for now though I hope to change that in the future.
See https://doc.rust-lang.org/cargo/reference/build-cache.html
This was referenced Nov 3, 2025
This was referenced Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with this is we can't compile doctests using
cargo_bin!. Unsure what the right answer is.