Add Command::absolute_path constructor
#102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
force-pushed
the
command-from-absolute-path
branch
from
184f6f9
to
981e665
Compare
stanislav-tkach
force-pushed
the
command-from-absolute-path
branch
from
981e665
to
76ab8ea
Compare
|
Could you help me understand how |
|
@epage Looks like I totally missed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it is the right approach to fix the #101 issue, but I would like to use the
CARGO_BIN_EXE_...environment variable.Additionally I'm not sure about naming. Logically it would be better to name the constructor
from_absolute_path, but is somewhat too long and existingcargo_binconstructor did not use the use "from" naming either.