Skip to content

Remove bower.json; add npm install exec; and fix version #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2018

Conversation

jbagga
Copy link
Contributor

@jbagga jbagga commented Mar 12, 2018

Removing bower.json file
Adding "npm install" to the msbuild file
3.2.7 has not been released yet. Reverting back to 3.2.7 since it was changed here #78 3.2.8 has already been released to npm

cc @kichalla

@jbagga jbagga requested a review from Eilon March 12, 2018 22:19
version.props Outdated
3.2.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, wait, shouldn't we be on 3.2.9 now? We never should have released 3.2.8 at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we release a 3.2.8 on NuGet at all then? Or re-do a release for both npm and NuGet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted in person. I think we should just "reset" and go to 3.2.9 at this point.

@jbagga jbagga merged commit 3ad6fe3 into master Mar 13, 2018
@jbagga jbagga deleted the jbagga/RemoveBowerFile branch March 13, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants