Webpack build with version 3.2.8 is failing

[martijnboland]

When using the latest version from NPM (3.2.8) with webpack, the following error occurres:

ERROR in ./node_modules/jquery-validation-unobtrusive/dist/jquery.validate.unobtrusive.js
Module not found: Error: Can't resolve 'jquery.validate' in '[path]\node_modules\jquery-validation-unobtrusive\dist'
 @ ./node_modules/jquery-validation-unobtrusive/dist/jquery.validate.unobtrusive.js 11:8-75
 @ multi bootstrap jquery jquery-validation jquery-validation-unobtrusive popper.js

I think webpack tries to resolve jquery.validate as a dependency (via AMD define) but it fails because it's probably known within webpack as jquery-validation. A workaround is to add the following rule to the webpack config:

module: {
  rules: [
    {
      parser: {
        amd: false,
      }
    }, 
   ...other rules...
  ]
}

[moise]

same issue here.

[dbengtsson]

Same here, downgrading to 3.2.6 works again. For those unfamiliar with semver: remove the ^ from package.json before 3.2.6 or it will force an update to 3.2.8 since it's a patchversion.

EDIT: Only read half the issue, as is tradition on the interwebs. Disabling AMD also works if you want to update.

[dbengtsson]

Can someone point me in the direction of why CommonJS uses "jquery-validation" and AMD uses jquery.validate" and "jquery.validate.unobtrusive" for module naming? I thought I'd fix this but quickly realized my knowledge of AMD is very limited.

[kyrylovych]

The problem is that jquery unobtrusive is trying to load module with name jquery.validate.
But such module is not valid because in latest version of jquery-validation export was defined as jquery
Check it here.
https://cdn.jsdelivr.net/npm/jquery-validation@1.17.0/dist/jquery.validate.js

(function( factory ) {
	if ( typeof define === "function" && define.amd ) {
		define( ["jquery"], factory );
	} else if (typeof module === "object" && module.exports) {
		module.exports = factory( require( "jquery" ) );
	} else {
		factory( jQuery );
	}
}(function( $ ) {
// jquery validation code 
})

I think this is bug in jquery-validation itself because docs says that you need to require dependency jquery.validate but not jquery.

So the quick fix would just replacing jquery.validate to jquery in jquery-validation-unobtrusive library or jquery to jquery.validate in jquery-validation library.

[kyrylovych]

Sorry guys,

I haven't noticed the brackets in define( ["jquery"], factory ).
This means that jquery validation is exported as anonymous module.
But still, you can access it by it's name (in our case - jquery-validation)

The only way to resolve this issue is to change required dependency name in jquery-validation-unobtrusive library

define("jquery.validate.unobtrusive", ['jquery.validate'], factory);

to

define("jquery.validate.unobtrusive", ['jquery-validation'], factory);

[mkArtakMSFT]

Thanks for reporting this issue. One of our engineers will look into this.

[mkArtakMSFT]

@kichalla, can you please look into this and evaluate what options do we have? Thanks

[Eilon]

BTW if we fix this, this fix would go into the next milestone, which is 3.2.9 (because we already pushed 3.2.8).

[li0nsar3c00l]

Any ETA, when this will be solved?

[Eilon]

@li0nsar3c00l no ETA at this time, but hopefully not too far out.