This repository was archived by the owner on Oct 10, 2018. It is now read-only.
Added PrepareWebSocketClient option #76
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue was moved to dotnet/aspnetcore#2488 |
|
Sorry I was a bad bot. Re-opening this PR. |
Author
|
@Tratcher @davidfowl can someone please take a look at this? |
Member
|
@saithis this is a prototype component that we don't have any near term plans to release. Making changes here is very low priority. If you're using this component and want to make changes I recommend you fork it. |
Contributor
|
I'm closing this PR as we are archiving this repo and moving all prototypes like this one into https://github.com/aspnet/asplabs. If you are still interested in contributing this change, please re-open your PR against https://github.com/aspnet/asplabs. Thanks, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was already a PrepareRequest for HttpRequests and with this we have the same for websockets. This PR replaces #75 as the rest of #75 is already possible in a better way, as described by @mkosieradzki .