[Fixes #429] FileResult #1190
[Fixes #429] FileResult #1190
Conversation
javiercn
commented
Sep 26, 2014
javiercn
commented
- Implemented FilePathResult to efficiently return files from disk.
- Implemented FileStreamResult to return content from a stream.
- Implemented FileContentResult to return content from a byte array.
There was a problem hiding this comment.
why not use stream's CopyToAsync?
There was a problem hiding this comment.
Might be an option, I want to know why they didn't use it in the first place
There was a problem hiding this comment.
I've investigated this and CopyTo does the same thing, so will change it.
|
Functional tests will be added later |
javiercn
force-pushed
the
issue429
branch
3 times, most recently
from
38968ea to
917c919
Compare
There was a problem hiding this comment.
@davidfowl Is this the right way to get the length of a file? or should I just use FileInfo directly?
There was a problem hiding this comment.
Need a file in disk for a test. I've followed a similar approach as Razor tests.
|
Updated |
There was a problem hiding this comment.
Also show an example where you provide the filename
|
|
when you get signoff from everyone else
There was a problem hiding this comment.
Needs a space after [NotNull]. Couple of other places with the same comment
There was a problem hiding this comment.
Stream.Null helps in case you need a stream that doesn't do anything.
|
|
|
Updated |
There was a problem hiding this comment.
Set Content-Length, or call SendAsync that will set it for you.
There was a problem hiding this comment.
We decided we don't want to set the Content-Lenght anywhere in MVC.
1) Implemented FilePathResult to efficiently return files from disk. 2) Implemented FileStreamResult to return content from a stream. 3) Implemented FileContentResult to return content from a byte array.
