Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Remove redundant if condition from ConsoleLogger #867

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Remove redundant if condition from ConsoleLogger #867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions src/Microsoft.Extensions.Logging.Console/ConsoleLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,19 +168,16 @@ public virtual void WriteMessage(LogLevel logLevel, string logName, int eventId,
logBuilder.AppendLine(exception.ToString());
}

if (logBuilder.Length > 0)
var hasLevel = !string.IsNullOrEmpty(logLevelString);
// Queue log message
_queueProcessor.EnqueueMessage(new LogMessageEntry()
{
var hasLevel = !string.IsNullOrEmpty(logLevelString);
// Queue log message
_queueProcessor.EnqueueMessage(new LogMessageEntry()
{
Message = logBuilder.ToString(),
MessageColor = DefaultConsoleColor,
LevelString = hasLevel ? logLevelString : null,
LevelBackground = hasLevel ? logLevelColors.Background : null,
LevelForeground = hasLevel ? logLevelColors.Foreground : null
});
}
Message = logBuilder.ToString(),
MessageColor = DefaultConsoleColor,
LevelString = hasLevel ? logLevelString : null,
LevelBackground = hasLevel ? logLevelColors.Background : null,
LevelForeground = hasLevel ? logLevelColors.Foreground : null
});

logBuilder.Clear();
if (logBuilder.Capacity > 1024)
Expand Down Expand Up @@ -299,4 +296,4 @@ public void WriteLine(string message)
}
}
}
}
}