Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Allow configuring the trace source logger without having to flow a TraceListener instance #405

Closed
@kevinchalet

Description

@kevinchalet

Unlike Katana's DiagnosticsLoggerFactory, the vNext equivalent now requires a TraceListener, which makes the trace source logger a bit painful to use in practice, since you can't simply rely on the listeners defined at the static level (that may be registered via the .config file on .NET Desktop)

Please consider updating TraceSourceLoggerProvider to make this parameter optional and offering a simpler AddTraceSource that doesn't require a specific trace listener.

@davidfowl do you remember why you had removed the parameterless constructor? https://github.com/aspnet/Logging/pull/143/files#diff-ca74d694fa53328497b21b4a9528dae5L28

/cc @muratg

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions