This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Add SPA middleware APIs to support new templates #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to merge this straight away because some other template work can't proceed until we get CI builds of the updated But this is still very much open to review and possible changes/reversions. |
rosieks
reviewed
Oct 6, 2017
| .Properties.Keys.OfType<AngularCliMiddleware>().FirstOrDefault(); | ||
| if (angularCliMiddleware == null) | ||
| { | ||
| throw new Exception( |
There was a problem hiding this comment.
Framework Design Guidelines: DO NOT throw Exception or SystemException.
rosieks
reviewed
Oct 6, 2017
| // for prerendering that returns complete HTML pages | ||
| if (renderResult.Globals != null) | ||
| { | ||
| throw new Exception($"{nameof(renderResult.Globals)} is not supported when prerendering via {nameof(UsePrerendering)}(). Instead, your prerendering logic should return a complete HTML page, in which you embed any information you wish to return to the client."); |
There was a problem hiding this comment.
Framework Design Guidelines: DO NOT throw Exception or SystemException.
rosieks
reviewed
Oct 6, 2017
| message += "Your application is running in Production mode, so make sure it has been published, or that you have built your SPA manually. Alternatively you may wish to switch to the Development environment.\n"; | ||
| } | ||
|
|
||
| throw new Exception(message); |
There was a problem hiding this comment.
Framework Design Guidelines: DO NOT throw Exception or SystemException.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new APIs allow for a more modern way to host a SPA inside an ASP.NET application:
None of these changes should affect backward compatibility. Existing SPA applications built with the current templates can continue to work fine and don't need to be updated.