Skip to content
This repository was archived by the owner on Nov 1, 2018. It is now read-only.

Fix test server issues. #1554

Merged
merged 8 commits into from
Oct 25, 2018
Merged

Fix test server issues. #1554

merged 8 commits into from
Oct 25, 2018

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Oct 24, 2018

Seems like delaying in dispose for a bit stops issues in hostable web core. Ran 100 times locally without failures. Unfortunate 😢

@jkotalik jkotalik requested a review from pakrym October 24, 2018 01:11
@jkotalik jkotalik changed the title Jkotalik/fix test server Fix test server issues. Oct 24, 2018
@pakrym
Copy link
Contributor

pakrym commented Oct 24, 2018

Didn't seem to help..

@jkotalik
Copy link
Contributor Author

Closing and reopening for more coverage.

@jkotalik jkotalik closed this Oct 24, 2018
@jkotalik jkotalik reopened this Oct 24, 2018
@jkotalik
Copy link
Contributor Author

Test failure: #1494

@pakrym
Copy link
Contributor

pakrym commented Oct 24, 2018

Does it work without sleep?

@jkotalik
Copy link
Contributor Author

jkotalik commented Oct 24, 2018 via email

@pakrym
Copy link
Contributor

pakrym commented Oct 24, 2018

Rerun PR multiple times please.

@jkotalik jkotalik closed this Oct 24, 2018
@jkotalik jkotalik reopened this Oct 24, 2018
@jkotalik jkotalik closed this Oct 24, 2018
@jkotalik jkotalik reopened this Oct 24, 2018
@pakrym pakrym closed this Oct 24, 2018
@pakrym pakrym reopened this Oct 24, 2018
@pakrym
Copy link
Contributor

pakrym commented Oct 24, 2018

Add a comment

@pakrym pakrym closed this Oct 25, 2018
@pakrym pakrym reopened this Oct 25, 2018
@pakrym pakrym closed this Oct 25, 2018
@pakrym pakrym reopened this Oct 25, 2018
@jkotalik jkotalik merged commit a9c5eb2 into release/2.2 Oct 25, 2018
@jkotalik jkotalik deleted the jkotalik/fixTestServer branch October 25, 2018 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants