This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Use object indirection in HttpContextAccessor #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Nov 16, 2018
| if (holder != null) | ||
| { | ||
| // Kill current HttpContext trapped in the AsyncLocals, as its done. | ||
| holder.Context = null; |
There was a problem hiding this comment.
If the context starts throwing dotnet/aspnetcore#3586; then it wouldn't necessarily have to clear it here?
The change of holder (below) would still prevent it being shared across requests.
There was a problem hiding this comment.
People use null to detect if they are in a request aware place.
|
Change the HttpContextFactory to not set the TraceIdentifier to null. Also tweak some of these tests https://github.com/aspnet/HttpAbstractions/pull/1021/files to avoid the TraceIdentifier comparison |
|
It's an extra allocation per request but async locals aren't super light anyways so this is fine. |
Tratcher
approved these changes
Nov 16, 2018
davidfowl
reviewed
Nov 16, 2018
davidfowl
approved these changes
Nov 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an extra level of indirection in
HttpContextAccessorso what is being held onto is shared (rather than its own reference); so when the request is done that second indirection can be cleared for everything holding on toHttpContextHolderat which point it will remain inert and they won't see data for the next request (as a newHttpContextHolderwill be created)