[REPL] Help improvements for repl #478
Conversation
| shellState.ConsoleManager.WriteLine(help); | ||
|
|
||
| var structuredCommand = command as CommandWithStructuredInputBase<HttpState, ICoreParseResult>; |
There was a problem hiding this comment.
This is an attempt to provide a consistent options help section for everything that needs it. Though I don't know that it's the best approach. Looking for ideas from you @mlorbetske.
There was a problem hiding this comment.
This is a reasonable way of going about this. I'm not a huge fan of this only working for things that derive from CommandWithStructuredInputBase<HttpState, ICoreParseResult>, but I don't see us adding additional commands that don't derive from that - making InputSpec public doesn't feel the best either, but I don't think it hurts anything.
We could add a method to get the options help to ICommand<,> and implement it in CommandWithStructuredInputBase<,> with the logic below - this would allow InputSpec to become protected again and lift the base type restriction, but it probably doesn't matter too much.
| helpText.AppendLine("Your default editor will be opened with a sample body if no options are provided."); | ||
| } | ||
|
|
||
| return helpText.ToString(); |
There was a problem hiding this comment.
Do we want to set these to a particular color from preferences?
Wanted to get a PR out with the help improvements that the version we showed Damian had: