Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

UserSecrets: align layout of targets in package to match supported frameworks #600

Merged
merged 1 commit into from
Feb 15, 2017
Merged

UserSecrets: align layout of targets in package to match supported frameworks #600

merged 1 commit into from
Feb 15, 2017

Conversation

natemcmaster
Copy link
Contributor

Resolves #599.

Instead of

build
└── netstandard1.0
    └── Microsoft.Extensions.Configuration.UserSecrets.targets

this rearranges the package layout to

build
├── GenerateUserSecretsAttribute.targets
├── net451
│   └── Microsoft.Extensions.Configuration.UserSecrets.targets
└── netstandard1.5
    └── Microsoft.Extensions.Configuration.UserSecrets.targets

@davidfowl
Copy link
Member

Any tests to verify the new behavior?

@natemcmaster
Copy link
Contributor Author

Build, pack, restore into a project.

davidfowl
davidfowl approved these changes Feb 11, 2017
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natemcmaster natemcmaster merged commit 50d6fe5 into dev Feb 15, 2017
@natemcmaster natemcmaster deleted the namc/targets branch February 15, 2017 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@Eilon Eilon Awaiting requested review from Eilon

@divega divega Awaiting requested review from divega

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natemcmaster @davidfowl @dnfclas