This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Fix infinite loop on empty first key section (#360). #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Assert.Equal(string.Empty, children.First().Key); | ||
| Assert.Equal(1, children.First().GetChildren().Count()); | ||
| Assert.Equal("Key2", children.First().GetChildren().First().Key); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I recommend either making this a theory and add more cases, or adding more Facts to cover a few more scenarios:
:foowhich you already coverfoo::barfoo::foo::bar
etc.
|
More tests, and |
cesarblum
force-pushed
the
cesarbs/empty-key-infinite-loop
branch
from
0059ab5
to
f4e4e53
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #360.
The solution is to distinguish between root calls to
ConfigurationRoot.GetChildrenImplementation()and subsequent recursive calls. So now passingnullto that method signals this is a root call, whereas passingstring.Emptymeans we're looking at a key section that has no name.