Update to MSBuild 16, .NET Core 3.0 Preview 2 SDK, and remove obsolete tasks and targets #935
Conversation
…asks, targets, and tools Instead of porting all these obsolete tasks and tools to MSBuild 16 and .NET Core 3, I've removed them in favor of simplifying KoreBuild
natemcmaster
force-pushed
the
feature/vs2019
branch
from
ab09d40 to
d674d98
Compare
natemcmaster
changed the title
There was a problem hiding this comment.
Seems great! I'm always down to delete some code. Did we already do a pass at removing the tasks/commands we're killing from the various repos that use them? If I recall correctly the auto-update script won't commit without a passing build, but it would still be nice to have an idea of what kind of problems we'll be facing before we merge this.
| catch { | ||
| Write-Host -f Red "vswhere output = $vswhereOut" | ||
| throw $_ | ||
| } |
There was a problem hiding this comment.
Curious (only): What changed that requires this try / catch now?
There was a problem hiding this comment.
Nothing changed. I added this to improve console output when something goes wrong. I was making testing changes to the vswhere code which had a bug and the error was hidden. I added this so I could see the problem, and figured it might be generally useful for the future.
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Internal.AspNetCore.Sdk"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
Will this change need to be made in all our repos?
There was a problem hiding this comment.
Yes, if there are any. I don't see anything using this pattern in the master branch anymore.
See dotnet/aspnetcore#7005. This PR is running on a version of build tools which has all of these changes that I produced from a "feature" branch build. Also, we don't have automation to update BuildTools in repos anymore. AspNetCore is the only repo using KoreBuild, and I updated it manually if necessary. When we move to arcade, we'll get tooling updates via Maestro. |
|
Updated based on PR feedback. I'll merge this soon-ish. I've validated aspnet + this change to build tools locally, but will waiting for the dnceng team to finish setting up VS2019 agents. |
|
Ready to merge VS2019 work today in AspNetCore. Merging this so we can get an updated BuildTools ready. |
Part of dotnet/aspnetcore#7005.
Resolves #881
Due to the large amount of breaking changes between MSBuild 15 and 16 (VS 2017 and VS 2019), I've decided to remove tasks broken by the upgrade instead of port them to a higher version.
Changes:
dockerbuild.shscript in aspnet/AspNetCore`)cc @ryanbrandenburg @Eilon