Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building projects which have custom implementations of 'Restore' and 'Test' targets #917

Merged
merged 4 commits into from
Jan 9, 2019
Merged

Support building projects which have custom implementations of 'Restore' and 'Test' targets #917

merged 4 commits into from
Jan 9, 2019

Conversation

natemcmaster
Copy link
Contributor

Support building projects which don't fit the vanilla C# template.

Examples:

  • C++
  • Wixproj
  • Custom projects, like shims projects that invoke another build system like npm

@natemcmaster natemcmaster changed the base branch from master to release/2.1 January 8, 2019 23:32
@natemcmaster natemcmaster mentioned this pull request Jan 8, 2019
Merged
@natemcmaster
Copy link
Contributor Author

Required to unblock dotnet/aspnetcore#6457

BrennanConroy
BrennanConroy approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how "_IsKoreBuildVsTestSupported" and "_IsProjectRestoreSupported" figure out which projects support what, but the rest makes sense.

@natemcmaster
Copy link
Contributor Author

I'll add comments to clarify.

@natemcmaster natemcmaster merged commit 1d35b6d into release/2.1 Jan 9, 2019
@natemcmaster natemcmaster deleted the namc/custom-proj-type branch January 9, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@ryanbrandenburg ryanbrandenburg Awaiting requested review from ryanbrandenburg

@mikaelm12 mikaelm12 Awaiting requested review from mikaelm12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natemcmaster @BrennanConroy