Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Microsoft.TestCommon more #400

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Mar 15, 2023

  • pre-restore and prebuild the project before anything that depends on it
    • avoid references from other test projects doing any real work
  • make ordering even more explicit
    • avoid confusion between batching builds and $(BuildInParallel)
  • turns out this also reduces the number of double writes binary logs show significantly

- pre-restore and prebuild the project before anything that depends on it
  - avoid references from other test projects doing any real work
- make ordering even more explicit
  - avoid confusion between batching builds and `$(BuildInParallel)`
- turns out this also reduces the number of double writes binary logs show significantly
@dougbu
Copy link
Member Author

dougbu commented Mar 15, 2023

Unfortunately, the PortReserver issues are still hurting in AzDO builds. I don't see them nearly as much in TeamCity (oddly enough). /cc @halter73 @Tratcher

@dougbu
Copy link
Member Author

dougbu commented Mar 15, 2023

TeamCity builds were the ones where I mainly saw problems w/ Microsoft.TestCommon. Using this branch, TeamCity builds #561 and #563 of Main.Integration was successful.

@Tratcher
Copy link
Member

Tratcher commented Mar 15, 2023

Trying to find a free port like that will always be racy. It's better for the server to retry binding until it finds a port.

@dougbu
Copy link
Member Author

dougbu commented Mar 15, 2023

Trying to find a free port like that will always be racy. It's better for the server to retry binding until it finds a port.

Thanks @Tratcher. Doesn't help my frustration w/ getting this PR in 😉 May either force the merge or just keep retrying until things work. I'm also open to adding a tactical fix here. I'm fine no matter the choice but am not going to dive into finding that workaround myself.

@dougbu dougbu merged commit 509661e into aspnet:main Mar 15, 2023
@dougbu dougbu deleted the dougbu/even.less.parallel branch March 15, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants