Add v29.x protoc versions #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Once merged, would it be possible to request a publish in the BCR? 🙏 |
alexeagle
approved these changes
Jan 31, 2025
|
yup i'll push a tag |
|
Thanks. much appreciated. |
steeve
pushed a commit
to zml/zml
that referenced
this pull request
Jan 31, 2025
This removes ~1300 build steps by depending on prebuilt binaries. Note that this PR is blocked by aspect-build/toolchains_protoc#44 since `rules_proto` depends on `protobuf@29.1` and https://github.com/aspect-build/toolchains_protoc doesn't expose `protoc@29.1` and we can't pin module versions unless adding an entry in the local BCR which I think is overkill for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #43
Add newer versions that were missed while the github action was not working.