chore: green up Windows CI #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
green_up_windows__macos
branch
from
2888a25 to
7547c72
Compare
|
Is this copied somewhere? Or is someone else more familiar with all this? |
This is to go-to for all our our rulesets. rules_rollup is the last one that is divergent. |
alexeagle
reviewed
May 8, 2024
|
Fwiw @jbedard I can't read that logic either 🤷 |
alexeagle
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bazel-contrib CI action
bazel-contrib/.github/.github/workflows/bazel.yaml@v6fails on Windows since Aspect CLI doesn't currently have a Windows binary in its releases. We work-around this issue in our GHA ci.yaml. There are also other fine grained knobs we get from our the GHA ci.yaml we use for all our other rulesets that this PR brings in such as fine grained control of flags passed to bazel && a more flexible matrix generator that can include RBE in the future.