Tags: aspect-build/rules_js
Tags
fix: overriding version of "pnpm" repo (#2883) The default `pnpm` repo was always taking priority and could not be overridden. See #2349 (comment) ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases - New test cases added
fix: watch pnpm-workspace.yaml (#2863) Otherwise changes will not (necessarily) trigger extension re-evalution. --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: no doc update needed. - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: no (suggested PR title if anything). ### Test plan - Covered by existing test cases - Manual testing: 1. `echo 9.1.0 > .bazelversion` 2. `cd e2e/bzlmod` 3. `bazel build :*` (build passes) 4. put `@asdf:` in `e2e/bzlmod/pnpm-workspace.yaml` (or some other invalid syntax) 5. `bazel build :*` (passes on main, fails with this PR as expected).
fix: revert buggy chdir simplification (#2829) Commit 19955f0 tried to simplify the `chdir` logic in the launcher script, but this introduced a bug in `js_test`. I believe the logic was correct for `js_binary` and `js_run_binary`, since those execute in the target bin directory, but it did not work for `js_test`, which executes in the runfiles directory. I added a new test case to cover this situation. Fixes #2827. --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Fixes #2827, a bug with `chdir` on `js_test` introduced in v3.1.0. ### Test plan - Covered by existing test cases - New test cases added
fix: handle missing packages in _collect_dep_constraints When an optional dependency is a "link:" dependency or otherwise not present in the `packages` dictionary, `npm_translate_lock` would fail with a "key not found" error such as: `Error: key "link:@angular/core|packages/core" not found in dictionary` This occurs because `_collect_dep_constraints` iterates over optional dependencies but assumes they all exist in the `packages` dictionary. Link dependencies are often not represented in the lockfile as standard packages, leading to this missing key.
PreviousNext