-
-
Notifications
You must be signed in to change notification settings - Fork 156
refactor: Port patches to label-store-less handling #2542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.x
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
| fail(msg) | ||
| _copy_input_file_legacy(priv, rctx, attr, label_store, patch_key) | ||
| _copy_input_file(priv, rctx, attr, workspace_path, str(rctx.path(patch)), repo_root) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy patchedDependencies patches into wrong repo path
When pnpm-lock.yaml sits in a Bazel subpackage, this block copies patchedDependencies patches to rctx.path(patch) without prefixing the lockfile’s package directory. _get_npm_imports later references patches as //{pnpm_lock.package}:{patch} (npm/private/npm_translate_lock_helpers.bzl lines 334‑349), so a lockfile under subdir/ will look for subdir/patches/... while the copy here writes patches/... at the repo root, leaving the expected file missing and patch application failing for non-root lockfiles.
Useful? React with 👍 / 👎.



Changes are visible to end-users: no
Test plan
existing