-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add 1p linked deps to e2e/js_image_oci #1710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
js_image_layer_1p_indirect_link
branch
from
May 7, 2024 22:10
6bda2ef
to
f5352cd
Compare
gregmagolan
force-pushed
the
js_image_layer_1p_indirect_link
branch
from
May 7, 2024 22:17
f5352cd
to
2aa12bc
Compare
gregmagolan
force-pushed
the
js_image_layer_1p_indirect_link
branch
from
May 7, 2024 22:18
2aa12bc
to
4210e99
Compare
@thesayyn do you have suggestions for how to add some assertions to this? |
jbedard
approved these changes
May 7, 2024
I added a basic one for the npm_package 1p dep that it's peer and direct deps can be required and are the expected versions. Good enough for now. More per layer assertions could be added in a follow-up. |
jbedard
pushed a commit
that referenced
this pull request
May 8, 2024
gregmagolan
added a commit
that referenced
this pull request
May 10, 2024
gregmagolan
added a commit
that referenced
this pull request
May 10, 2024
gregmagolan
added a commit
that referenced
this pull request
May 13, 2024
jbedard
pushed a commit
to jbedard/rules_js
that referenced
this pull request
May 14, 2024
jbedard
pushed a commit
that referenced
this pull request
May 14, 2024
jbedard
pushed a commit
to jbedard/rules_js
that referenced
this pull request
May 16, 2024
gregmagolan
added a commit
that referenced
this pull request
May 20, 2024
gregmagolan
added a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test coverage for indirect 1p dep links (via npm_package).
Pre-factor for adding support in js_image_layer for direct 1p dep links (js_library links).