Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 1p linked deps to e2e/js_image_oci #1710

Merged
merged 1 commit into from
May 7, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented May 7, 2024

Adds test coverage for indirect 1p dep links (via npm_package).

Pre-factor for adding support in js_image_layer for direct 1p dep links (js_library links).

@gregmagolan gregmagolan requested a review from jbedard May 7, 2024 22:08
@gregmagolan gregmagolan force-pushed the js_image_layer_1p_indirect_link branch from 6bda2ef to f5352cd Compare May 7, 2024 22:10
Copy link

aspect-workflows bot commented May 7, 2024

Test

All tests were cache hits

190 tests (100.0%) were fully cached saving 51s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 467ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 693ms.


Test

e2e/js_image_oci

1 test target passed

Targets
//src:image_test [k8-fastbuild]8s

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 845ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 773ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 248ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 511ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 451ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 393ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.


Buildifier      Format

@gregmagolan gregmagolan force-pushed the js_image_layer_1p_indirect_link branch from f5352cd to 2aa12bc Compare May 7, 2024 22:17
@gregmagolan gregmagolan force-pushed the js_image_layer_1p_indirect_link branch from 2aa12bc to 4210e99 Compare May 7, 2024 22:18
@jbedard jbedard requested a review from thesayyn May 7, 2024 22:29
@jbedard
Copy link
Member

jbedard commented May 7, 2024

@thesayyn do you have suggestions for how to add some assertions to this?

@gregmagolan
Copy link
Member Author

@thesayyn do you have suggestions for how to add some assertions to this?

I added a basic one for the npm_package 1p dep that it's peer and direct deps can be required and are the expected versions. Good enough for now. More per layer assertions could be added in a follow-up.

@gregmagolan gregmagolan merged commit d2affac into 2.x May 7, 2024
105 checks passed
@gregmagolan gregmagolan deleted the js_image_layer_1p_indirect_link branch May 7, 2024 22:35
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 14, 2024
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants